RPC runtime for python #9 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kanghyojun
commented
Jul 30, 2016
•
kanghyojun
commented
- Implement Service, WsgiApp to create nirum rpc service
- Add nirum.rpc.WsgiApp, nirum.rpc.Service
- Return appropriate error message / success response
- Support /ping/ by default
- Fix deserializers
- deserialize by class not from given data
- deserialize generic type(eg. typing.Sequence) as python type
- deserialize primitive type
| @@ -25,6 +25,7 @@ def get_version(): | |||
|
|
|||
| install_requires = [ | |||
| 'setuptools', | |||
| 'werkzeug >= 0.11, < 0.12', | |||
There was a problem hiding this comment.
PyPI 핸들 이름으로는 첫 글자가 대문자로 되어 있던데…
- Implement Service, WsgiApp to create nirum rpc service - Add nirum.rpc.WsgiApp, nirum.rpc.Service - Return appropriate error message / success response - Support /ping/ by default - Fix deserializers - deserialize by class not from given data - deserialize generic type(eg. typing.Sequence) as python type - deserialize primitive type
| if type_ is data_type: | ||
| return True | ||
| else: | ||
| return False |
|
|
||
| def deserialize_primitive(cls, data): | ||
| if cls is datetime.datetime: | ||
| d = datetime.datetime.strptime(data, '%Y-%m-%dT%H:%M:%S.%f') |
| ) | ||
| if not callable(service_method): | ||
| return self.error( | ||
| 400, | ||
| request, | ||
| message="Remote procedure '{}' is not callable.".format( | ||
| request_method | ||
| method_facial_name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.