WIP: Add stub of JavaScript target #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kroisse
changed the title
Kroisse
force-pushed
the
javascript-target
branch
from
9c6e975 to
8ab0f6b
Compare
dahlia
reviewed
Mar 25, 2017
| @@ -135,6 +144,7 @@ test-suite spec | |||
| , nirum | |||
| , parsec | |||
| -- only for dealing with htoml's ParserError | |||
| , pretty >=1.1.3 && <2 | |||
There was a problem hiding this comment.
As aeson,aeson-pretty and pretty are common dependencies to library and test-suite spec, it'd better omit version specifies here.
| @@ -0,0 +1,84 @@ | |||
| {-# LANGUAGE FlexibleInstances, GeneralizedNewtypeDeriving, MultiParamTypeClasses, TypeOperators #-} | |||
There was a problem hiding this comment.
Please keep shorter than 80 columns for each line.
| toJavaScriptFilename :: ModulePath -> [FilePath] | ||
| toJavaScriptFilename mp = | ||
| case mp of | ||
| ModulePath { .. } -> |
There was a problem hiding this comment.
You can simply match this by ModulePath {} ->.
| | i <- toList path | ||
| ] | ||
| ++ [ f moduleName ] | ||
| ModuleName { .. } -> |
|
|
||
|
|
||
| compileModule :: Module -> CodeBuilder () | ||
| compileModule Module {..} = do |
Kroisse
added a commit
to Kroisse/nirum
that referenced
this pull request
Apr 20, 2017
dahlia
added
the
cmp:compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
야 신 난 다