Proper unit tests for Python __hash__() behavior #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[changelog skip]
dahlia
added
typ:bug
Whereas GNU sed's -i/--in-place option optionally takes an argument (which is a suffix, and means to modify the input file in place if you omit an argument), BSD sed's -i option always takes an argument even if it's an empty string (e.g., -i ''). My solution is install GNU sed using Homebrew on macOS build. Note that omitting --with-default-names will prepend "g" to the command, i.e., gsed. [changelog skip]
dahlia
force-pushed
the
python-hash-tests
branch
from
b199ce3 to
225b182
Compare
Codecov Report
@@ Coverage Diff @@
## 0.3-maintenance #244 +/- ##
===================================================
- Coverage 73.28% 72.77% -0.52%
===================================================
Files 28 29 +1
Lines 2216 2233 +17
Branches 123 123
===================================================
+ Hits 1624 1625 +1
- Misses 469 485 +16
Partials 123 123
Continue to review full report at Codecov.
|
dahlia
added a commit
to dahlia/nirum
that referenced
this pull request
Mar 10, 2018
Cherry-picked from: nirum-lang#244
dahlia
added a commit
to dahlia/nirum
that referenced
this pull request
Mar 10, 2018
Whereas GNU sed's -i/--in-place option optionally takes an argument (which is a suffix, and means to modify the input file in place if you omit an argument), BSD sed's -i option always takes an argument even if it's an empty string (e.g., -i ''). My solution is install GNU sed using Homebrew on macOS build. Note that omitting --with-default-names will prepend "g" to the command, i.e., gsed. Cherry-picked from: nirum-lang#244
Cherry-picked from d80195a [changelog skip]
dahlia
force-pushed
the
python-hash-tests
branch
from
ae7d0d4 to
208b222
Compare
kanghyojun
approved these changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there's likely no bugs in generated Python
__hash__()methods, unit tests for__hash__()had been seriously incorrect.