Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __nirum_annotations__ on record type #320

Closed
wants to merge 3 commits into from
Closed

Add __nirum_annotations__ on record type #320

wants to merge 3 commits into from

Conversation

AlanSynn
Copy link
Contributor

Add __nirum_annotations__ on record type.

@kanghyojun
Copy link
Member

@AlanSynn I think we missed that tracking an annotation-test-record in test/nirum_fixture/fixture/foo.nrm file. Could you add it on this PR?

@AlanSynn
Copy link
Contributor Author

@admire93 Oops... My apologies. I'll add it in the morning.
(Cause I'm on my way to setting my mac for daily uses, Sorry!)

@kanghyojun
Copy link
Member

kanghyojun commented Aug 17, 2018

@AlanSynn It's fine :) Thanks to your contribution!! Have a nice day. It might be needed to be rebased because of confliction on CHANGES.md.

@AlanSynn
Copy link
Contributor Author

@admire93 Yeah I got that one too. I've already rebased my branch. Thanks!

@AlanSynn AlanSynn closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants