Generalize CodeGen to use it for other targets #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (cg >>= return) `shouldBe` cg | ||
| specify "associativity" $ do | ||
| ((cg >>= f) >>= f') `shouldBe` (cg >>= (\x -> f x >>= f')) | ||
| ((cg >>= f') >>= f) `shouldBe` (cg >>= (\x -> f' x >>= f)) |
There was a problem hiding this comment.
이 테스트들은 두 가지 이유 때문에 제거되었습니다.
- 이제
CodeGen은ExceptT와StateT의 조합으로 구현되는데, 이 라이브러리들이 이미Monad를 잘 구현하고 있다고 가정할 수 있습니다. StateT가Eq와Show를 구현하지 않아,CodeGen도 그 타입클래스를 구현할 수 없고, 그래서shouldBe를 쓸 수 없습니다.
| @@ -19,6 +19,7 @@ cabal-version: >=1.10 | |||
|
|
|||
| library | |||
| exposed-modules: Nirum.Cli | |||
| , Nirum.CodeGen | |||
There was a problem hiding this comment.
별거 아니지만 Nirum.Compiler.CodeGen 정도로 안쪽에 집어넣는 건 어떨까요? (물론 아직 Nirum.Compiler 같은 공간은 아직 없지만 곧 필요할 것 같아서…)
There was a problem hiding this comment.
실제로 필요하게 될 때 옮겨도 그다지 늦지 않을 것 같습니다.
|
기존에 👍 |
|
중간에 WIP 커밋이 그대로 있기도 하고 해서 squash & merge하겠습니다. |
|
리뷰도 못봤네요 수고많으셨습니다 |
dahlia
added
the
cmp:compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation of #50, to insert the information which version of Python code will be generated, in the code generation progress.