cachebuster the wrong way around?

[robinst]

Setting params.cachebuster to true results in links like this:

<link rel="stylesheet" href="/css/reset.css">

Setting it to false uses the unix timestamp as a query param, see here. This means clients will have to load the files again when the site is rebuilt. Isn't that supposed to be "cache busting"? Seems the wrong way around.

[nishanths]

Thanks for catching. Yes, I made a mistake in this commit: 6e2e423

[robinst]

Thanks :). With cachebusting turned on, I now get this:

ERROR: 2016/12/04 15:56:32 template.go:132: template: theme/partials/head_includes.html:25:46: executing "theme/partials/head_includes.html" at <.Now.Unix>: can't evaluate field Now in type interface {} in theme/partials/head_includes.html

[nishanths]

Thanks! It looks like .Now does not exist any more. Sigh, it was undocumented anyway.

Even when it did exist, it appears it returned the time associated with the page, not the current time. So cachebuster would not have been working anyway.

Possible solution is to make a pull request to hugo adding a "now" function that returns time.Now().
This is the related code in hugo: https://github.com/spf13/hugo/blob/master/tpl/template_funcs.go#L2018
I'll get to it in a couple of days!

I'll disable cachebuster by default in config.toml until we can sort this out.

[nishanths]

dependent on hugo pr: gohugoio/hugo#2859

[nishanths]

Done in 2e598e5.

works for me with hugo 0.18.
@robinst please feel free to reopen if you have issues. thanks for patience!

Related thread for future: https://discuss.gohugo.io/t/proposal-replace-page-now/4968