Fix resources so they honor .Site.BaseURL #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory L. Dietsche <gregory.dietsche@cuw.edu>
lpancescu
reviewed
Jun 11, 2017
| @@ -21,7 +21,7 @@ | |||
| {{ end }} | |||
| {{ end }} | |||
| {{ $srcset := delimit ($.Scratch.Get "srcset") "," }} | |||
| <a {{ printf "href=%q" ("/" | relLangURL) | safeHTMLAttr }}><img class="avatar" src="/{{ .Site.Params.avatar }}" {{ printf "srcset=%q" $srcset | safeHTMLAttr }}></a> | |||
| <a {{ printf "href=%q" ("/" | relLangURL) | safeHTMLAttr }}><img class="avatar" src="{{ .Site.BaseURL }}{{ .Site.Params.avatar }}" {{ printf "srcset=%q" $srcset | safeHTMLAttr }}></a> | |||
There was a problem hiding this comment.
Wouldn't .Site.BaseURL also be needed as the target of the avatar link (the round image at the top of the page), as well as when clicking on the name right below it? Perhaps Hugo already writes the links correctly, never placed a site in a subdirectory.
|
waiting for merged 👍 |
|
Do you have plans to merge it @nishanths ? |
| @@ -46,7 +46,7 @@ | |||
| {{ if .Site.Params.faviconfile }} | |||
| href="/{{ .Site.Params.faviconfile }}" | |||
| {{ else }} | |||
| href="/img/favicon.ico" | |||
| href="{{ .Site.BaseURL }}img/favicon.ico" | |||
There was a problem hiding this comment.
Not sure if you noticed but there is an extra white space after BaseURL. 😅
Thanks for your PR, it helped me to solve a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out the theme from a relative location, I found problems.
For example if baseurl is set to "http://mysite/hugo/" then the image and css links
were wrong in the past because of the "hugo" sub directory.
Signed-off-by: Gregory L. Dietsche gregory.dietsche@cuw.edu