Add an outcome tag to RestTemplate metrics similar to that provided f…

…or WebMVC and WebFlux spring-projects#15420
nishantraut · Dec 31, 2018 · 7b91df6 · 7b91df6
1 parent c0fbaa9
commit 7b91df6
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/...va/org/springframework/boot/actuate/metrics/web/client/RestTemplateExchangeTagsTests.java b/...va/org/springframework/boot/actuate/metrics/web/client/RestTemplateExchangeTagsTests.java
@@ -31,6 +31,8 @@
  */
 public class RestTemplateExchangeTagsTests {
 
+	private MockClientHttpResponse response;
+
 	@Test
 	public void outcomeTagIsUnknownWhenResponseStatusIsNull() {
 		Tag tag = RestTemplateExchangeTags.outcome(null);
@@ -39,41 +41,39 @@ public void outcomeTagIsUnknownWhenResponseStatusIsNull() {
 
 	@Test
 	public void outcomeTagIsInformationalWhenResponseIs1xx() {
-		MockClientHttpResponse response = new MockClientHttpResponse("foo".getBytes(),
-				HttpStatus.CONTINUE);
-		Tag tag = RestTemplateExchangeTags.outcome(response);
+		this.response = new MockClientHttpResponse("foo".getBytes(), HttpStatus.CONTINUE);
+		Tag tag = RestTemplateExchangeTags.outcome(this.response);
 		assertThat(tag.getValue()).isEqualTo("INFORMATIONAL");
 	}
 
 	@Test
 	public void outcomeTagIsSuccessWhenResponseIs2xx() {
-		MockClientHttpResponse response = new MockClientHttpResponse("foo".getBytes(),
-				HttpStatus.OK);
-		Tag tag = RestTemplateExchangeTags.outcome(response);
+		this.response = new MockClientHttpResponse("foo".getBytes(), HttpStatus.OK);
+		Tag tag = RestTemplateExchangeTags.outcome(this.response);
 		assertThat(tag.getValue()).isEqualTo("SUCCESS");
 	}
 
 	@Test
 	public void outcomeTagIsRedirectionWhenResponseIs3xx() {
-		MockClientHttpResponse response = new MockClientHttpResponse("foo".getBytes(),
+		this.response = new MockClientHttpResponse("foo".getBytes(),
 				HttpStatus.MOVED_PERMANENTLY);
-		Tag tag = RestTemplateExchangeTags.outcome(response);
+		Tag tag = RestTemplateExchangeTags.outcome(this.response);
 		assertThat(tag.getValue()).isEqualTo("REDIRECTION");
 	}
 
 	@Test
 	public void outcomeTagIsClientErrorWhenResponseIs4xx() {
-		MockClientHttpResponse response = new MockClientHttpResponse("foo".getBytes(),
+		this.response = new MockClientHttpResponse("foo".getBytes(),
 				HttpStatus.BAD_REQUEST);
-		Tag tag = RestTemplateExchangeTags.outcome(response);
+		Tag tag = RestTemplateExchangeTags.outcome(this.response);
 		assertThat(tag.getValue()).isEqualTo("CLIENT_ERROR");
 	}
 
 	@Test
 	public void outcomeTagIsServerErrorWhenResponseIs5xx() {
-		MockClientHttpResponse response = new MockClientHttpResponse("foo".getBytes(),
+		this.response = new MockClientHttpResponse("foo".getBytes(),
 				HttpStatus.BAD_GATEWAY);
-		Tag tag = RestTemplateExchangeTags.outcome(response);
+		Tag tag = RestTemplateExchangeTags.outcome(this.response);
 		assertThat(tag.getValue()).isEqualTo("SERVER_ERROR");
 	}