Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BMI calculator example #130

Merged
merged 2 commits into from
Oct 12, 2023
Merged

BMI calculator example #130

merged 2 commits into from
Oct 12, 2023

Conversation

lutaii
Copy link
Contributor

@lutaii lutaii commented Sep 24, 2023 •
edited by nisrulz
Loading

What does this implement/fix? Explain your changes
BMI Calculator example

Does this close any currently open issues?
Issue #103

  • Where has this been tested?

    • iPhone 14 Pro

    • Pixel 3A

  • Target Platform:
    iOS/Android

  • Walkthrough:

@lutaii
Copy link
Contributor Author

lutaii commented Sep 24, 2023

Hey @nisrulz.
Please review my pull request.

nisrulz
nisrulz reviewed Sep 24, 2023
View reviewed changes
Copy link
Owner

@nisrulz nisrulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to address. This PR needs some work.

Additionally, also note

  • You need to add a link back in readme index
  • Update the package name

bmi_calculator/lib/main.dart Outdated Show resolved Hide resolved
bmi_calculator/lib/result_page.dart Outdated Show resolved Hide resolved
bmi_calculator/lib/calculator_page.dart Outdated Show resolved Hide resolved
bmi_calculator/pubspec.yaml Outdated Show resolved Hide resolved
@lutaii lutaii requested a review from nisrulz October 2, 2023 08:24
@lutaii
Copy link
Contributor Author

lutaii commented Oct 2, 2023

Hey @nisrulz. Can you review my changes once again?

@lutaii
Copy link
Contributor Author

lutaii commented Oct 11, 2023

Hey @nisrulz
Can I merge this pr?

@nisrulz nisrulz mentioned this pull request Oct 12, 2023
Closed
@nisrulz
Copy link
Owner

nisrulz commented Oct 12, 2023

Hi @lutaii I still need to take a look at this PR. I'll try to merge open PRs in the next 2-3 days.

@nisrulz nisrulz merged commit 36c8bed into nisrulz:develop Oct 12, 2023
@nisrulz nisrulz mentioned this pull request Oct 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisrulz nisrulz Awaiting requested review from nisrulz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lutaii @nisrulz