Merge pull request #1441 from tonyqus/Clonesheet_1370_fix

Fix Clone sheet when the sheet contains hyperlinks
nissl-lab · Nov 10, 2024 · 148d805 · 148d805
2 parents e99f945 + 3dc47a8
commit 148d805
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/ooxml/XSSF/UserModel/XSSFWorkbook.cs b/ooxml/XSSF/UserModel/XSSFWorkbook.cs
@@ -626,7 +626,7 @@ public ISheet CloneSheet(int sheetNum, String newName)
                     if (pr.TargetMode == TargetMode.External)
                     {
                         clonedSheet.GetPackagePart().AddExternalRelationship
-                            (pr.TargetUri.OriginalString, pr.RelationshipType, null);
+                            (pr.TargetUri.OriginalString, pr.RelationshipType, pr.Id);
                     }
                 }
             }

diff --git a/testcases/ooxml/XSSF/UserModel/TestCloneSheet.cs b/testcases/ooxml/XSSF/UserModel/TestCloneSheet.cs
@@ -0,0 +1,18 @@
+using NUnit.Framework;
+using System.IO;
+
+namespace NPOI.XSSF.UserModel
+{
+    [TestFixture]
+    public class TestCloneSheet
+    {
+        [Test]
+        public void TestCloneHyperlink()
+        {
+            using(var workbook = XSSFTestDataSamples.OpenSampleWorkbook("1370_clonesheet_withhyperlink.xlsx"))
+            {
+                workbook.CloneSheet(0,"Sheet2");
+            }
+        }
+    }
+}
diff --git a/testcases/test-data/spreadsheet/1370_clonesheet_withhyperlink.xlsx b/testcases/test-data/spreadsheet/1370_clonesheet_withhyperlink.xlsx