Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null reference check in UpdateHeaders() to allow formatting existing data as table #1035

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

superrnovae
Copy link
Contributor

Currently if the AreaReference passed to SetCellReferences() contains any data, UpdateHeaders() will fail with null reference exception. This pull request fixes that by adding a null reference check.

Closes #1026

@tonyqus tonyqus added this to the NPOI 2.6.1 milestone Mar 19, 2023
@superrnovae
Copy link
Contributor Author

Would you like me to include a test case?

@tonyqus
Copy link
Member

tonyqus commented Mar 19, 2023

Would you like me to include a test case?

Yes, it would be great!

@superrnovae
Copy link
Contributor Author

Yes, it would be great!

Done.

@tonyqus tonyqus merged commit 8789235 into nissl-lab:master Apr 26, 2023
tonyqus added a commit that referenced this pull request Apr 26, 2023
@superrnovae superrnovae deleted the fix_updateheaders branch March 5, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XSSFTable SetCellReferences() fails with exception if the referenced area is not empty
2 participants