Enable tests in CI runs #1092
Merged
Enable tests in CI runs #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
enable-ci-tests
branch
12 times, most recently
from
d64f691
to
ae3c34d
Compare
* fix and ignore faulty ones * update test libraries * fix file name case sensitivity * less warnings in build output
|
LGTM |
|
https://github.com/nissl-lab/npoi/actions/runs/5281266886
According to this post, we should install used fonts in the Linux container. Reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good to have safety net when PRs are being offered. As not all of them run at the moment need to ignore some of them unfortunately. I've either used
TODO FIX CI TESTSorTODO NOT IMPLEMENTEDdepending on the error that is thrown. So now there are known non-passing but new PRs shouldn't introduce new test problems as builds will fail.Results as part of the run summary at the bottom:
https://github.com/nissl-lab/npoi/actions/runs/5168784413
After this is merged, I think I am brave enough to offer my first optimization PR that I have ready 😉