Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #983 INT(1.99) doesn't return correct rounded value #1109

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

deleteJ
Copy link
Contributor

@deleteJ deleteJ commented Jun 28, 2023

This closes #983

Since in excel INT function definition is "Rounds a number down to the nearest integer", change the function from Math.Round to Math.Floor

@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Jun 28, 2023
@tonyqus
Copy link
Member

tonyqus commented Jun 29, 2023

LGTM

@tonyqus tonyqus merged commit 32435d9 into nissl-lab:master Jun 29, 2023
@tonyqus tonyqus modified the milestones: NPOI 2.7.0, NPOI 2.6.2 Aug 23, 2023
@tonyqus tonyqus added the bug label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INT(1.99) doesn't return correct rounded value
2 participants