Workbook Evaluator bug fix on checking an IF without a third param #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyqus
approved these changes
Sep 5, 2023
|
Hello @tonyqus |
|
@fred2020-net Yeah, I'll review this ticket this week or next week. But please understand that 2.7.0 is not a release happening soon. 2.6.2 is just released last week. Usually, it takes 3-5 month to have another release. So far, NPOI is still a free component under Apache 2.0 license. I use my spare time to maintain it and in other words, it's a hobby project. If NPOI changes license to commercial in the future, the situation can be different. We will have promise on commercial clients and will have a fixed release cycle (for example, monthly release or even biweekly release). |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluation stack not empty is throwed when using an IF without a third param
formula example:
=IF(C37="8E";"CH8E-1";IF(C37="8F";"CH8F-2"))
in case of FALSE of condition C37="8E" then the exception is thrown.
Solution found on looking at the source code:
https://svn.apache.org/repos/asf/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/WorkbookEvaluator.java
Bug introduced in this commit:
e3ba38b#r126492380