-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SixLabors dependencies #1264
Conversation
Update SixLabors dependencies to address ImageSharp DDOS security issue
I notice
Do you have any consideration of using SixLabors.ImageSharp 2.1.6 and SixLabors.Font 1.0.1? |
In v2 the license has been changed, but I see it's safe to update in NPOI. Will update the PR if you don't see any issues. |
SixLabors.ImageSharp 3.1.2 is .net 6+ only and this would cause end of .net framework and net standard 2.x support. DON't do this. In their code they also changed it to .net8 only. 2.1.6 got the security fix backported and is fine to use. |
I still think SkiaSharp is a better suited for NPOI for these reasons:
BenchmarkDotNet v0.13.12, Windows 10 (10.0.19045.3930/22H2/2022Update)
Here is a benchmark code (from SixLabors.Font project):
|
create a PR for the NPOI 2.7.1. Version 2.7.0 is scheduled for End February, so having such a breaking change needs more testing time. |
Let's see what @tonyqus think about it. The cons for SixLabors is it 100% managed |
I agree with @MagicAndre1981. It's safer to use SkiaSharp in the release 2.7.1. It may cause some breaking changes and even Autoresize may stop working. |
Thanks, anyway this PR should be merged to 2.7.0 |
New Security Update from SixLabors |
Update SixLabors dependencies to address ImageSharp DDOS security issue