Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Concat Function #1341

Merged
merged 2 commits into from
May 9, 2024
Merged

Implement Concat Function #1341

merged 2 commits into from
May 9, 2024

Conversation

dcjxdd123
Copy link

@dcjxdd123 dcjxdd123 commented May 8, 2024

Fix #1088, Implement CONCAT function , add Some Tests

@dcjxdd123 dcjxdd123 changed the title Xdddevelop Implement Concat Function May 8, 2024
@dcjxdd123
Copy link
Author

what should i do next ? just wait review ?

@tonyqus tonyqus added this to the NPOI 2.7.1 milestone May 9, 2024
@tonyqus
Copy link
Member

tonyqus commented May 9, 2024

LGTM

@tonyqus tonyqus merged commit 9049540 into nissl-lab:master May 9, 2024
2 of 3 checks passed
@rbalanag
Copy link

rbalanag commented May 22, 2024

Hi @tonyqus , any updates on the said issue? I've observed that a pipeline build is failing.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONCAT function is not working.
3 participants