Remove static locale state, fixes #358 #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LocaleUtil.SetUserTimeZone is still necessary to allow user to use various timezone. I'll try to reimplement it. |
|
I would advice you to reconsider. You'll be "reimplementing" a variable. Don't waste effort holding static state for the caller. It's better to let the caller decide the details like scope of their own variables. When you try to decide these things for the caller, you will get bugs like the #358 we started with. It's a foot gun. |
|
I agree with the creator of this PR. I just got burned by this issue and was completely surprised to see this library manipulating static state. It basically caused an operation to succeed once and then fail the next time for the exact same inputs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the foot gun.