Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal support Pivot tables, Fix #419, Fix #262 #708

Merged
merged 4 commits into from
Feb 7, 2022

Conversation

KnyazSh
Copy link

@KnyazSh KnyazSh commented Nov 29, 2021

The main problem, the solution of which was the purpose of these changes, is to fill excel files with complex graphs and pivot tables using npoi, i.e. using such files as templates. I tested these changes on a relatively large file with several pivot charts, including slicers. I have not checked the creation of the Pivot tables and charts themselves in npoi, although I think it is possible.

Also please pay attention to CT_AlternateContent in [OpenXmlFormats/Vml/SpreadsheetDrawing.cs.](url) I had errors when using innerXml and had to use outerXml. I assume that something is lost by using wrapped innerXml.

@tonyqus
Copy link
Member

tonyqus commented Dec 14, 2021

Before accepting the PR, I suggest you use LoadAndSaveBack tool to test if your change will break the file. Use this tool to load a xlsx file that contains pivot table and see if Excel can still open it after saving back. I used this tool to find a lot of bugs in ooxml implementation.

@KnyazSh
Copy link
Author

KnyazSh commented Jan 13, 2022

Before accepting the PR, I suggest you use LoadAndSaveBack tool to test if your change will break the file. Use this tool to load a xlsx file that contains pivot table and see if Excel can still open it after saving back. I used this tool to find a lot of bugs in ooxml implementation.

Thanks for the advice. I already did these tests when I wrote these changes. The main purpose was to remove the error after reading-writing a file.

@tonyqus tonyqus modified the milestones: NPOI 2.5.7, NPOI 2.5.6 Jan 17, 2022
@tonyqus
Copy link
Member

tonyqus commented Feb 4, 2022

Instead of merging to master, I'd like to create a new branch called Pivot-table.

@tonyqus tonyqus modified the milestones: NPOI 2.5.6, NPOI 2.5.7 Feb 4, 2022
@tonyqus tonyqus changed the base branch from master to Pivot-table February 7, 2022 18:43
@tonyqus tonyqus merged commit 958ba17 into nissl-lab:Pivot-table Feb 7, 2022
@tonyqus tonyqus modified the milestones: NPOI 2.6.1, NPOI 2.6.0 Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants