Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of Workseet CopyTo #942

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

EmilienDup
Copy link
Contributor

Simplifying time complexity of CopyTo methods by copying merged regions at once.

Simplifying time complexity of `CopyTo` methods by copying merged regions at once.
@EmilienDup
Copy link
Contributor Author

Hi,

I've updated this Pull Request.
It is not behind the master branch anymore.

Added unit tests are working on my machine, the GH check fails but it is probably not due to the changes introduced by this PR.

Any chance this change could make it to the next release?

If you'd like me to do additional changes, let me know.

Thanks

@tonyqus
Copy link
Member

tonyqus commented Dec 14, 2023

LGTM

@tonyqus tonyqus merged commit ae62bd1 into nissl-lab:master Dec 14, 2023
2 of 3 checks passed
@tonyqus tonyqus changed the title fix/Workseet-CopyTo-performance Improve performance of Workseet CopyTo Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants