-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring XSSFRow #949
Refactoring XSSFRow #949
Conversation
Add regions. Nothing is changed in the code, members just moved around
I find your version much easier to read. |
@PBrunot I'm a bit conflicted on the use of expression body myself, it makes code a little less cluttered, but does it help readability or hurts it? I'm not sure, to me it seems like neither. But since it does reduce clutter - decided to roll with it. The language support, of course, is a legitimate issue, but I test the code on multiple targets including .net framework 4.6.2, and no language compatibility issues were raised while testing. Anyway, not married to the idea, let's see what @tonyqus (and/or others) think and if need be, I'll switch it back to full method bodies. |
To be honest, I'm not a fans of expression body and var. NPOI used to support very old .NET framework (such as 2.0 and 3.x). I have a habit to avoid using new C# syntax feature since it may break the compilation. I'm fine with the following changes:
|
Brings back block bodies for methods and properties; Brings back use of explicit types instead of 'var'
@tonyqus I've addressed your comments in the recent commit. Thanks for the input! |
LGTM |
Code clean-up, refactor into more of C# style code, use expression body style for properties and methods where applicable, use 'var' instead of explicit types where possible, add curly brackets for clarity in places where they were omitted, re-arrange members into regions.
Change javadoc to c# xml documentation.
No changes in code itself or logic, only refactoring.