Final fix for climate react switch enabled not working properly #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I adjusted to code according to the discussion above and tested it. I guess that's it :) @benwebbbenwebb |
|
Thanks @seidnerj Merged |
benwebbbenwebb
pushed a commit
that referenced
this pull request
Nov 11, 2023
* Fixed StateHandler setter not firing for `enableClimateReactSwitch` * Adjust `enableClimateReactAutoSetup` logic
benwebbbenwebb
pushed a commit
that referenced
this pull request
Nov 11, 2023
* Fixed StateHandler setter not firing for `enableClimateReactSwitch` * Adjust `enableClimateReactAutoSetup` logic
|
I just found a small (but critical) bug in this feature, it affects ANY configuration, even if the auto setup feature is off. I will have a PR ready very soon - I am testing it today. |
benwebbbenwebb
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Fixed StateHandler setter not firing for `enableClimateReactSwitch` * Adjust `enableClimateReactAutoSetup` logic
benwebbbenwebb
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Fixed StateHandler setter not firing for `enableClimateReactSwitch` * Adjust `enableClimateReactAutoSetup` logic
benwebbbenwebb
added a commit
that referenced
this pull request
Jan 20, 2024
### Bug fixes and improvements - #105 fan setting not remembered, round HKToFanLevel to match fanLeveltoHK - StateHandler.js - Better handle async (WIP) API calls, especially for smartMode - StateHandler.js - Correctly manage smartMode state changes - api.js - Better error handling - api.js - updated fixResponse to prevent unexpectedly adding smartMode - README.md changes - Climate React feature descriptions - Sensor descriptions - added deprecations - general clean up - config and config.schema updates - move StateHandler.js - move HKToFanLevel, toFahrenheit, sensiboFormattedACState & sensiboFormattedClimateReactState to (new) StateHandler.js - add Utils.js and move to using Utils.updateValue() - Additional logging and TODOs - Only add Humidity to AC when enabled ### Security - Bump axios from 0.21.4 to 1.6.5 - Bump follow-redirects to 1.15.4 ### Chores and maintenance - update package.json dependency and engine versions - Axios major version upgrade - remove qs (functionality now provided by Axios directly) - move to eslint stylistic (from eslint) for linting - ESLint flat file config (v9 ready) - add/update GitHub workflow to check linting on PRs - update .gitignore and .npmignore - move nodemon to own config - TODOs, comments and debug log changes - Tidied up / unified accessory definition files --------- Co-authored-by: seidnerj (PRs #119 & #122, #123 back merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.