Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re and fullMatch do not work outside main module on Nim devel #1

Closed
honewatson opened this issue Jan 13, 2018 · 1 comment
Closed

re and fullMatch do not work outside main module on Nim devel #1

honewatson opened this issue Jan 13, 2018 · 1 comment

Comments

@honewatson
Copy link

Due to step and toPattern not being public.
honewatson pushed a commit to honewatson/nim-regex that referenced this issue Jan 14, 2018
Fixes nitely#1 and adds beginning of unit tests
77d5d30
honewatson pushed a commit to honewatson/nim-regex that referenced this issue Jan 14, 2018
Fixes nitely#1 and adds beginning of unit tests
9ed3946
honewatson pushed a commit to honewatson/nim-regex that referenced this issue Jan 14, 2018
Fixes nitely#1 and adds beginning of unit tests
767f129
@nitely
Copy link
Owner

nitely commented Jan 14, 2018

Hey,

Thanks for reporting this and sending a PR. As I commented it on the PR, I was bitten by nim-lang/Nim#7085 🤕

@nitely nitely closed this as completed Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@honewatson @nitely