Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #129
Reorder the epsilon transitions to be evaluated after the matchable node:
@[matchable_node_idx, epsilon_transition_idx]
.It helps avoiding pointless capts evaluation on regex with alternations:
(foo|bar|...)
. Currently capts are evaluated for all alternations, even if only one matches. Note(foo|bar|...)
translates to(foo)|(bar)|...
internally to remove epsilon transition states, although all capts refer to the same capt node.This improves #138 somewhat when using findAll (
contains
uses the no-capts optimization so no changes there).This branch:
Master: