Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hostels schema #208

Merged
merged 1 commit into from
Aug 31, 2024
Merged

feat: hostels schema #208

merged 1 commit into from
Aug 31, 2024

Conversation

heydoyouknowme0
Copy link
Contributor

image
rest data improbable to change so left in i18n

@GetPsyched
Copy link
Member

Wouldn't you want to initialise the hostels schema into master first, and then rebase sample-db onto master?

GetPsyched
GetPsyched previously approved these changes Aug 29, 2024
@GetPsyched
Copy link
Member

Wait, no. Put the overview and stuff into the schema. The data being improbable to change is no reason to not put it in there. Please don't use that as a criterion.

@GetPsyched GetPsyched merged commit 5e8bc2b into master Aug 31, 2024
1 check passed
@GetPsyched GetPsyched deleted the hostel-schema branch August 31, 2024 12:16
@GetPsyched
Copy link
Member

Rebase sample-db on master and add sample data in that branch

@heydoyouknowme0 heydoyouknowme0 restored the hostel-schema branch September 1, 2024 13:47
@heydoyouknowme0
Copy link
Contributor Author

heydoyouknowme0 commented Sep 1, 2024

I messed up.
image
didnt realize employeeId is a varchar, it links properly inside studio but doesn't actually fetch when I try to fetch using the relation(which i realized when rebasing hostels page).

two many to one relation between same table dont work unless I use two different ids to do so

Edit: employee id seems to be int in actual data just changing that might also work

@GetPsyched
Copy link
Member

As a lesson, always test your changes before moving the PR out of a draft

@heydoyouknowme0
Copy link
Contributor Author

There was no indication of an error anywhere even after pushing to the db ˙◠˙

also what should I do now
we can either make employee id an integer or another multi table relation(like staff)

@GetPsyched
Copy link
Member

Um, that relation looks wrong though. Why is an employeeId being linked to a hostel id? Even if we made the datatypes match, why would they logically ever match?

@heydoyouknowme0
Copy link
Contributor Author

heydoyouknowme0 commented Sep 1, 2024

uhhh, Im sorry everything's broken
I'm stupid

KambojRajan pushed a commit that referenced this pull request Sep 23, 2024
som-04 pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants