Fix examples #15
Merged
Fix examples #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion out into the public methods so that private methods can assume that is already done. And added missing conversion in third party caveat method.
…mples. Replaced hard-coded future dates with dynamic dates to avoid additional timebombs.
|
Awesome, thank you very much. Great idea to include the Examples in the unit tests. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples were found to be broken by the recent changes. Added unit test to ensure those breaks get caught in the future.
Also changed hard-coded future dates (timebombs) to be dynamic to avoid additional issues down the road.
And did some refactoring to push key derivation out to the public methods to make it easier to determine whether it's been done or not.