Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more familiar builder API and Java methods name, essentially not exposing
MacaroonsBuilder
directly but viaMacaroon.builder()
methods, and changing the builders method to be more inline with Java naming conventions.This also moves all static methods that returns a
Macaroon
directly has a static method ofMacaroon
itself:This is entirely backward compatible for now, but all methods that would need to be changed or removed in the future have been marked as deprecated.