bring back check for duration string might be empty

nitram509 · Nov 10, 2023 · 6c67876 · 6c67876
1 parent e840b0e
commit 6c67876
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/bpmn_engine/timer.go b/pkg/bpmn_engine/timer.go
@@ -2,6 +2,7 @@ package bpmn_engine
 
 import (
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/nitram509/lib-bpmn-engine/pkg/spec/BPMN20"
@@ -125,5 +126,9 @@ func findExistingTimerNotYetTriggered(state *BpmnEngineState, id string, instanc
 }
 
 func findDurationValue(ice BPMN20.TIntermediateCatchEvent) (duration.Duration, error) {
-	return duration.ParseISO8601(ice.TimerEventDefinition.TimeDuration.XMLText)
+	durationStr := ice.TimerEventDefinition.TimeDuration.XMLText
+	if len(strings.TrimSpace(durationStr)) == 0 {
+		return duration.Duration{}, newEngineErrorf("Can't find 'timeDuration' value for INTERMEDIATE_CATCH_EVENT with id=%s", ice.Id)
+	}
+	return duration.ParseISO8601(durationStr)
 }