-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for projects using prisma orm #497
Conversation
issues caused by bundling and needing to run prisma generate in the final containers. Added fixes for when a prisma folder is detected.
89eb164
to
e0719b7
Compare
Another fix for the bundling issue could be to remove that process from our typescript container. It's unclear how much of a performance improvement that adds at runtime. We could also move to |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #497 +/- ##
===========================================
+ Coverage 20.05% 20.15% +0.10%
===========================================
Files 31 31
Lines 1960 1965 +5
===========================================
+ Hits 393 396 +3
- Misses 1544 1545 +1
- Partials 23 24 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
3134c2a
to
99c3372
Compare
🎉 This PR is included in version 1.18.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
We may remove these fixes in future and allow developers to resolve these issues themselves through custom docker files. For now though, they have no impact on projects that aren't running prisma.
Related issues can be found here: