Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for projects using prisma orm #497

Merged
merged 5 commits into from
May 22, 2023
Merged

fixes for projects using prisma orm #497

merged 5 commits into from
May 22, 2023

Conversation

jyecusch
Copy link
Member

@jyecusch jyecusch commented May 19, 2023

We may remove these fixes in future and allow developers to resolve these issues themselves through custom docker files. For now though, they have no impact on projects that aren't running prisma.

Related issues can be found here:

issues caused by bundling and needing to run prisma generate in the final containers. Added fixes for when a prisma folder is detected.
@jyecusch
Copy link
Member Author

Another fix for the bundling issue could be to remove that process from our typescript container. It's unclear how much of a performance improvement that adds at runtime.

We could also move to tsup with skipNodeModulesBundle: true to avoid bundling dependencies. That would give us a single entrypoint to run without breaking dependencies like prisma.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 15.78% and project coverage change: +0.10 🎉

Comparison is base (7128d55) 20.05% compared to head (99c3372) 20.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #497      +/-   ##
===========================================
+ Coverage    20.05%   20.15%   +0.10%     
===========================================
  Files           31       31              
  Lines         1960     1965       +5     
===========================================
+ Hits           393      396       +3     
- Misses        1544     1545       +1     
- Partials        23       24       +1     
Flag Coverage Δ
unittests 20.15% <15.78%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/codeconfig/codeconfig.go 8.43% <ø> (+0.06%) ⬆️
pkg/runtime/csharp.go 0.00% <0.00%> (ø)
pkg/runtime/golang.go 18.75% <0.00%> (ø)
pkg/runtime/javascript.go 27.27% <0.00%> (ø)
pkg/runtime/python.go 25.00% <0.00%> (-2.28%) ⬇️
pkg/runtime/types.go 63.15% <ø> (ø)
pkg/runtime/typescript.go 27.27% <0.00%> (ø)
pkg/build/build.go 31.03% <42.85%> (+2.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jyecusch jyecusch force-pushed the fix/prisma-support branch from 3134c2a to 99c3372 Compare May 22, 2023 00:01
@jyecusch jyecusch merged commit 5ce52ae into develop May 22, 2023
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants