Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to lint and validate the nitric.yaml from json schema #735

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davemooreuws
Copy link
Member

@davemooreuws davemooreuws commented Jun 12, 2024

Note: Used a simple lock file for version check instead of parsing the JSON each time.

Should test against a published version of vscode ext before merging.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 1.29%. Comparing base (6e0a93d) to head (25546f4).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/schemas/schemas.go 0.00% 44 Missing ⚠️
pkg/paths/paths.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #735      +/-   ##
========================================
- Coverage   1.30%   1.29%   -0.01%     
========================================
  Files         78      79       +1     
  Lines       8224    8270      +46     
========================================
  Hits         107     107              
- Misses      8109    8155      +46     
  Partials       8       8              
Flag Coverage Δ
unittests 1.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant