Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): support custom baseURL #1062

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix(azure): support custom baseURL #1062

merged 1 commit into from
Mar 17, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #1061
nuxt/nuxt#19385

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds support for custom baseURLs by nesting the public directory with the correct prefix. (We still have to write our empty index.html in the root, though.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working preset:azure labels Mar 16, 2023
@danielroe danielroe requested a review from pi0 March 16, 2023 10:39
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1062 (990cc99) into main (7a6c5b4) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
- Coverage   67.40%   67.32%   -0.09%     
==========================================
  Files          62       62              
  Lines        6283     6292       +9     
  Branches      707      707              
==========================================
+ Hits         4235     4236       +1     
- Misses       2034     2042       +8     
  Partials       14       14              
Impacted Files Coverage Ξ”
src/presets/azure.ts 8.72% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit fd15c21 into main Mar 17, 2023
@pi0 pi0 deleted the fix/azure-base-url branch March 17, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preset:azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure preset, reference to compiled assets failing.
2 participants