feat(cache): support cached event handlers with varies #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
pi0
reviewed
Apr 24, 2023
|
@pi0 any updates on this? |
Codecov Report
@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
- Coverage 76.38% 76.33% -0.06%
==========================================
Files 73 73
Lines 7550 7550
Branches 745 744 -1
==========================================
- Hits 5767 5763 -4
- Misses 1782 1785 +3
- Partials 1 2 +1 |
pi0
force-pushed
the
feature/1031-support-cached-event-handlers-with-varies
branch
from
225805b
to
f8711a5
Compare
pi0
approved these changes
Aug 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 #1031
❓ Type of change
📚 Description
Resolves #1031
Adds an optional property varies to the cache options.
If varies option is present in the requests headers the value will be considered in key generation.
So if someone sets
varies: [ 'host' ]example.com and exmaple.de will generate different cache entries📝 Checklist