Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply chunkFileNames on windows #1189

Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix: apply chunkFileNames on windows #1189

merged 2 commits into from
Apr 25, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#15244

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We currently use startsWith but the chunk on windows has backslashes so this needs to be normalised first to match our internal buildServerDir.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working windows labels Apr 25, 2023
@danielroe danielroe requested a review from pi0 April 25, 2023 16:05
@danielroe danielroe self-assigned this Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1189 (c5b2639) into main (720fe29) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1189   +/-   ##
=======================================
  Coverage   77.19%   77.20%           
=======================================
  Files          67       67           
  Lines        6639     6641    +2     
  Branches      734      734           
=======================================
+ Hits         5125     5127    +2     
  Misses       1513     1513           
  Partials        1        1           
Impacted Files Coverage Ξ”
src/rollup/config.ts 89.58% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit b9370be into main Apr 25, 2023
@pi0 pi0 deleted the fix/windows-chunks branch April 25, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants