-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added aws via flightcontrol docs #1249 #1250
Conversation
β Live Preview ready!
|
This was previously opened here: #970 |
@pi0 could you please review this |
@ModupeD Just checking - is there a difference between this PR and the one already open? |
@danielroe the other one is outdated and cannot be edited, so my boss asked me to create a new one |
Codecov Report
@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
+ Coverage 76.83% 76.91% +0.07%
==========================================
Files 68 69 +1
Lines 6829 6835 +6
Branches 692 693 +1
==========================================
+ Hits 5247 5257 +10
+ Misses 1580 1577 -3
+ Partials 2 1 -1
|
Perfect - got it π |
Co-authored-by: Daniel Roe <daniel@roe.dev>
hey @pi0, gentle nudge on this one :) |
Hi, @ModupeD thanks for reworking this doc PR, and sorry for the delay in merging. To ensure the quality of officially listed deployment providers, we usually do a deployment with nitro-deploys playground (which still have to do) Respecting the original author's request I've applied your changes via e7936d9 and will be merged via #970 once deploy confirmed. Feel free to make any other PRs to the main and improve docs and preset β€οΈ Cheers. |
π Linked issue
β Type of change
π Description
This change adds a new deployment provider to Nitro: deploying to AWS via Flightcontrol. Flightcontrol helps you deploy your Nitro projects (Both static & SSR) to your own AWS account with little to no configuration.
π Checklist