Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added aws via flightcontrol docs #1249 #1250

Closed
wants to merge 4 commits into from

Conversation

ModupeD
Copy link
Contributor

@ModupeD ModupeD commented May 17, 2023

πŸ”— Linked issue

❓ Type of change

  • [ x] πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change adds a new deployment provider to Nitro: deploying to AWS via Flightcontrol. Flightcontrol helps you deploy your Nitro projects (Both static & SSR) to your own AWS account with little to no configuration.

πŸ“ Checklist

  • [x ] I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented May 17, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview d2fde1d

@ModupeD ModupeD mentioned this pull request May 17, 2023
1 task
@ModupeD ModupeD marked this pull request as ready for review May 17, 2023 20:20
@ModupeD ModupeD mentioned this pull request May 18, 2023
7 tasks
@ModupeD
Copy link
Contributor Author

ModupeD commented May 18, 2023

This was previously opened here: #970

@ModupeD
Copy link
Contributor Author

ModupeD commented May 30, 2023

@pi0 could you please review this

@danielroe
Copy link
Member

@ModupeD Just checking - is there a difference between this PR and the one already open?

@ModupeD
Copy link
Contributor Author

ModupeD commented May 30, 2023

@danielroe the other one is outdated and cannot be edited, so my boss asked me to create a new one

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1250 (d2fde1d) into main (2ad4389) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
+ Coverage   76.83%   76.91%   +0.07%     
==========================================
  Files          68       69       +1     
  Lines        6829     6835       +6     
  Branches      692      693       +1     
==========================================
+ Hits         5247     5257      +10     
+ Misses       1580     1577       -3     
+ Partials        2        1       -1     
Impacted Files Coverage Ξ”
src/presets/flightcontrol.ts 100.00% <100.00%> (ΓΈ)
src/presets/index.ts 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@danielroe
Copy link
Member

Perfect - got it πŸ‘Œ

Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe danielroe requested a review from pi0 May 30, 2023 18:35
@flybayer
Copy link

hey @pi0, gentle nudge on this one :)

@pi0
Copy link
Member

pi0 commented Jun 20, 2023

Hi, @ModupeD thanks for reworking this doc PR, and sorry for the delay in merging. To ensure the quality of officially listed deployment providers, we usually do a deployment with nitro-deploys playground (which still have to do)

Respecting the original author's request I've applied your changes via e7936d9 and will be merged via #970 once deploy confirmed.

Feel free to make any other PRs to the main and improve docs and preset ❀️

Cheers.

@pi0 pi0 closed this Jun 20, 2023
pi0 added a commit that referenced this pull request Jun 20, 2023
Co-authored-by: ModupeD <69601432+ModupeD@users.noreply.github.com>
Co-authored-by: Pooya Parsa <pooya@pi0.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants