Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow configuring all esbuild transform #1347

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix: allow configuring all esbuild transform #1347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a7e58a
fix: allow configuring esbuild transform plugin
danielroe Jun 25, 2023
665b5a8
Merge branch 'main' into fix/esbuild-options
pi0 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 22 additions & 31 deletions src/rollup/plugins/esbuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { Plugin, PluginContext } from "rollup";
import { Loader, TransformResult, transform } from "esbuild";
import { createFilter } from "@rollup/pluginutils";
import type { FilterPattern } from "@rollup/pluginutils";
import type { TransformOptions } from "esbuild";

const defaultLoaders: { [ext: string]: Loader } = {
".ts": "ts",
Expand All @@ -13,39 +14,33 @@ const defaultLoaders: { [ext: string]: Loader } = {
".jsx": "jsx",
};

export type Options = {
export interface Options extends TransformOptions {
include?: FilterPattern;
exclude?: FilterPattern;
sourceMap?: boolean | "inline" | "hidden";
minify?: boolean;
target: string | string[];
jsxFactory?: string;
jsxFragment?: string;
define?: {
[k: string]: string;
};
/**
* Use this tsconfig file instead
* Disable it by setting to `false`
*/
tsconfig?: string | false;
/**
* Map extension to esbuild loader
* Note that each entry (the extension) needs to start with a dot
*/
loaders?: {
[ext: string]: Loader | false;
};
};
}

export function esbuild(options: Options): Plugin {
const loaders = {
...defaultLoaders,
};

if (options.loaders) {
for (const key of Object.keys(options.loaders)) {
const value = options.loaders[key];
const {
include,
exclude,
sourceMap,
loaders: loadersConfig,
minify,
...transformOptions
} = options;

const loaders = { ...defaultLoaders };
if (loadersConfig) {
for (const key of Object.keys(loadersConfig)) {
const value = loadersConfig[key];
if (typeof value === "string") {
loaders[key] = value;
} else if (value === false) {
Expand All @@ -61,8 +56,8 @@ export function esbuild(options: Options): Plugin {
const EXCLUDE_REGEXP = /node_modules/;

const filter = createFilter(
options.include || INCLUDE_REGEXP,
options.exclude || EXCLUDE_REGEXP
include || INCLUDE_REGEXP,
exclude || EXCLUDE_REGEXP
);

return {
Expand All @@ -81,13 +76,9 @@ export function esbuild(options: Options): Plugin {
}

const result = await transform(code, {
sourcemap: sourceMap === "hidden" ? "external" : sourceMap,
...transformOptions,
loader,
target: options.target,
jsxFactory: options.jsxFactory,
jsxFragment: options.jsxFragment,
define: options.define,
sourcemap:
options.sourceMap === "hidden" ? "external" : options.sourceMap,
sourcefile: id,
});

Expand All @@ -102,11 +93,11 @@ export function esbuild(options: Options): Plugin {
},

async renderChunk(code) {
if (options.minify) {
if (minify) {
const result = await transform(code, {
loader: "js",
minify: true,
target: options.target,
target: transformOptions.target,
});
if (result.code) {
return {
Expand Down