Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect sourceMap option #141

Merged
merged 3 commits into from
Apr 22, 2022
Merged

fix: respect sourceMap option #141

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac8efc2
fix: default esbuild sourceMap option
danielroe Apr 21, 2022
69f348a
refactor: set `sourceMap` default to true
danielroe Apr 22, 2022
156a323
Merge remote-tracking branch 'origin/main' into fix/esbuild-sourcemap
danielroe Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rollup/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export const getRollupConfig = (nitro: Nitro) => {
// esbuild
rollupConfig.plugins.push(esbuild({
target: 'es2019',
sourceMap: true,
sourceMap: nitro.options.sourceMap !== false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please set the default in options.ts to be same for every usage?

...nitro.options.esbuild?.options
}))

Expand Down