fix(cache): try to call event.waitUntil
#1422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#1420
β Type of change
π Description
Based on #1421, try to call
event.waitUntil
for the cache update operation if the first parameter indefineCachedFunction
is an event and always fordefineCachedEventHandler
.Previously we were using a dangling background promise which was not being ended on Cloudflare workers.
(this is an experimental fix without introducing new API)
π Checklist