Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove auto-imported defineNitroConfig #1441

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Jul 16, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since the defineNitroConfig is auto-imported, I think that we could safely remove import from examples.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Jul 16, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 76f0cc1

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #1441 (8fdd59d) into main (e87e2ba) will not change coverage.
The diff coverage is n/a.

❗ Current head 8fdd59d differs from pull request most recent head 76f0cc1. Consider uploading reports for the commit 76f0cc1 to get more accurate results

@@           Coverage Diff           @@
##             main    #1441   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files          73       73           
  Lines        7437     7437           
  Branches      728      728           
=======================================
  Hits         5665     5665           
  Misses       1771     1771           
  Partials        1        1           

@Hebilicious Hebilicious added the documentation Improvements or additions to documentation label Jul 17, 2023
@Hebilicious Hebilicious requested a review from pi0 July 17, 2023 06:50
@Hebilicious
Copy link
Contributor

Thanks for making this PR !
I have a slight preference for the way things currently are, but I'm not too opinionated either way. @pi0 will decide.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 1b9f51b into nitrojs:main Jul 17, 2023
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants