Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): exclude encoded href attributes from link extraction #1485

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

farnabaz
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Nitro detects href from an encoded html

Example html

<span class="ct-948368">&lt;a href=&quot;https://nuxtjs.org&quot;&gt;External link html&lt;/a&gt;
</span>

With this PR extractLinks will ignore links starting with &quot;

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Jul 25, 2023

Thanks for PR and example.

Is it possible to add this to the tests as well?

@Hebilicious Hebilicious added prerender bug Something isn't working labels Jul 28, 2023
@pi0 pi0 changed the title fix(prerender): link extraction regex respect encoded html fix(prerender): exclude encoded strings from link extraction Aug 6, 2023
@pi0 pi0 changed the title fix(prerender): exclude encoded strings from link extraction fix(prerender): exclude encoded href attributes from link extraction Aug 6, 2023
@pi0 pi0 merged commit 1b9815f into nitrojs:main Aug 6, 2023
5 checks passed
@pi0 pi0 mentioned this pull request Aug 21, 2023
@manniL manniL mentioned this pull request Jan 23, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prerender
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants