-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: prefer snake_case for preset names #1499
Conversation
I have to set `cloudflare_pages` in my `nuxt.config.ts` in order for this preset to work. I assume that means that the preset should be underscored and not dashed like `cloudflare-pages`.
β Live Preview ready!
|
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
+ Coverage 76.25% 76.28% +0.03%
==========================================
Files 73 73
Lines 7453 7540 +87
Branches 733 739 +6
==========================================
+ Hits 5683 5752 +69
- Misses 1769 1787 +18
Partials 1 1 |
|
Thanks for PR @marshallswain . As @Hebilicious pointed out, there is no difference in two casings because we use camel case normalization using unjs/scule and it handles both casings... However i think as a general best practice, underscores are safer to be in docs ππΌ (refactoring to reflect other pages too) |
β Type of change
π Description
This updates the preset for Cloudflare Pages to be named
cloudflare_pages
instead ofcloudflare-pages
. This brings the name inline with the one on the https://nitro.unjs.io/deploy page and actually works when deploying to Cloudflare Pages.I have to set
cloudflare_pages
in mynuxt.config.ts
in order for this preset to work. I assume that means that the preset should be underscored and not dashed likecloudflare-pages
. If I usecloudflare-pages
instead ofcloudflare_pages
, thedist
directory does not get created.π Checklist