Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use relative paths in tsconfig.json #1518

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Without a baseUrl we cannot pass in absolute paths in nitro aliases. This ensures that our aliases + includes are relative to the tsconfig file itself.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1518 (8b0663c) into main (6217581) will decrease coverage by 0.02%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   76.26%   76.25%   -0.02%     
==========================================
  Files          73       73              
  Lines        7466     7478      +12     
  Branches      732      734       +2     
==========================================
+ Hits         5694     5702       +8     
- Misses       1771     1775       +4     
  Partials        1        1              
Files Changed Coverage Ξ”
src/build.ts 85.32% <61.11%> (-0.49%) ⬇️

@pi0 pi0 merged commit 451d314 into main Aug 2, 2023
5 of 6 checks passed
@pi0 pi0 deleted the fix/relative-tsconfig-paths branch August 2, 2023 07:06
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants