-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(plugins): add runtime hooks section #1521
Conversation
β Live Preview ready!
|
- Introduce new guide section for hooks, including examples with hook callback argument types. - Move hooks examples from Guides/Plugins into Guides/Hooks. - Add Hook documentation for new on/before/after request hooks.
Codecov Report
@@ Coverage Diff @@
## main #1521 +/- ##
==========================================
+ Coverage 76.25% 76.28% +0.03%
==========================================
Files 73 73
Lines 7478 7540 +62
Branches 734 739 +5
==========================================
+ Hits 5702 5752 +50
- Misses 1775 1787 +12
Partials 1 1 |
Thanks for helping on this @gnoeley <3 In the meantime, I think it makes more sense to keep runtime hooks section under the plugins because that's how mainly they should be registered and used. I have made few changes to merge, added link and list of available routes an additional example for error. When adding two new (upcoming) hooks for global request, after-reponse, i will extend your current work on new section (therefore merging your PR sooner to iterate. You are more than welcome to open more to improve.) |
Looks great, agree with your decisions on the changes. Will raise more in the future if I spot gaps and think I can help. |
Looking forward to more! BTW for your info: #1545 |
π Linked issue
#1301
β Type of change
π Description
Attempt to more explicitly outline the available hooks and their usage for Nitro server. This could help support the addition of more hooks in the linked issue.
π Checklist