fix(prerender): free up memory after each route is written to the disk #1536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #1535
β Type of change
π Description
This PR resolves the high memory usage issue when prerendering lots of routes by cleaning up the memory of route contents as soon as being written to the disk.
Since we were already typing the
route.data
androute.contents
as optional, as a non breaking change they are only available (and can be set) before disk write. We could additionally support reading back contents from disk when accessing.data
and.contents
getters using fs sync methods but I think we can do it only if necessary.Testing on reproduction in #1535 there seems no memory leaks anymore generating all 100k routes.
π Checklist