fix: use relative source map paths and add test #1582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Currently, we were always generating sourcemaps with absolute paths.
This PR makes nitro to follow default rollup behavior (generating relating sourcemap paths). This makes them portable (running in production assuming
.output
is adjustant to the same expected source structure and also in development mode.It is worth to note that, we need
NODE_OPTIONS=--enable-source-maps
flag to lerage sourcemaps (documentation to be improved).I have added a small test to make sure sourcemap works.
π Checklist