Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): safe error message override #1712

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

romanzipp
Copy link
Contributor

πŸ”— Linked issue

#1711

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I was trying if my current Nuxt project will just work under Bun. Installing packages & starting the dev builder works just fine but when visiting the dev server url, I get faced with the attached error which seems to alter a property on an passed readonly argument.

Resolves #1711

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title Fix overriding readonly property on worker error callback fix(dev): safe error message override Sep 26, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1712 (b3eecef) into main (c3565d8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
- Coverage   77.17%   77.16%   -0.01%     
==========================================
  Files          75       75              
  Lines        7911     7912       +1     
  Branches      802      802              
==========================================
  Hits         6105     6105              
- Misses       1803     1804       +1     
  Partials        3        3              
Files Coverage Ξ”
src/dev/server.ts 83.88% <0.00%> (-0.31%) ⬇️

@pi0 pi0 merged commit 949ef91 into nitrojs:main Sep 26, 2023
7 of 8 checks passed
@pi0 pi0 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error building Nuxt project on Bun "Attempted to assign readonly property"
2 participants