Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): allow all h3 handled body types #1755

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This updates the handling of render response to allow directly returning a stream as well as a string.

Feedback welcome on concept. We could alternatively create a new helper that could handle other common stream-related issues.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 23, 2023
@danielroe danielroe requested a review from pi0 September 23, 2023 07:05
@danielroe danielroe self-assigned this Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #1755 (64c7397) into main (f84c282) will increase coverage by 0.00%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

❗ Current head 64c7397 differs from pull request most recent head 9ac4f91. Consider uploading reports for the commit 9ac4f91 to get more accurate results

@@           Coverage Diff           @@
##             main    #1755   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files          75       75           
  Lines        7893     7911   +18     
  Branches      806      806           
=======================================
+ Hits         6099     6113   +14     
- Misses       1792     1796    +4     
  Partials        2        2           

see 2 files with indirect coverage changes

src/runtime/renderer.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: directly return stream in render handler fix(renderer): allow rendering stream Sep 26, 2023
@pi0 pi0 changed the title fix(renderer): allow rendering stream fix(renderer): allow all h3 handled body types Sep 26, 2023
@pi0 pi0 merged commit d5f8804 into main Sep 26, 2023
3 of 6 checks passed
@pi0 pi0 deleted the fix/stream-response branch September 26, 2023 16:14
@pi0 pi0 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants