Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add jsdoc for cache.maxAge #1878

Merged
merged 1 commit into from
Nov 2, 2023
Merged

chore: add jsdoc for cache.maxAge #1878

merged 1 commit into from
Nov 2, 2023

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Nov 2, 2023 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I never know if it's in seconds or in ms so I ask a comment.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes requested a review from pi0 November 2, 2023 15:12
@Barbapapazes Barbapapazes self-assigned this Nov 2, 2023
@Barbapapazes Barbapapazes added the documentation Improvements or additions to documentation label Nov 2, 2023
@pi0 pi0 changed the title docs: add comment for cache.maxAge chore: add jsdoc for cache.maxAge Nov 2, 2023
@pi0 pi0 merged commit b4fab4c into main Nov 2, 2023
3 of 5 checks passed
@pi0 pi0 deleted the Barbapapazes-patch-1 branch November 2, 2023 17:42
@pi0 pi0 mentioned this pull request Nov 19, 2023
Closed
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@pi0 pi0 pi0 approved these changes

Assignees

@Barbapapazes Barbapapazes

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Barbapapazes @manniL @pi0