-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: initialize nitro app before plugins run #1906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for making PR. Although it is slightly a breaking/risky behavior change i was considering to do similar change also in order to allow async plugins. I will carefully review it soon to make sure we won't break anything before moving forward. |
(delaying to next minor) -- update marked as draft to investigate more |
pi0
approved these changes
Sep 20, 2024
Thank you!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This is more of a proof-of-concept to highlight the issue and maybe offer a solution, feel free to close for your own solution.
The issue is that when a plugin wants to make an internal fetch, if that endpoint is using
useNitroApp
, then it will fail. This is because plugins are ran without the nitroApp context being available.I've got around it previously using a timeout "hack" (harlan-zw/nuxt-link-checker@646e6ff), but as has been pointed out, this isn't exactly reliable (nuxt-modules/sitemap#149 (comment)).
π Checklist