-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show meta framework name on server build success #1955
feat: show meta framework name on server build success #1955
Conversation
This is nice idea! Only we could show Both Nitro version and framework like |
Alright! Will push the change in a bit :) |
@pi0 Is this good or should I colorize? I pushed the change to show both Nitro & Framework info |
I like the output but looking at the screenshot, seems too verbose no? We might try to colorize indeed and gray out versions or maybe just show names to be shorter. (ideas welcome to try different modes) |
On an unrelated note: If you are on Discord would you DM me please? Would love you to have you in UnJS server :) |
I don't know which discord it is @pi0 π¬ |
I will play around more with the colors then let you know when I'm done :) |
@pi0 Here's the latest screenshots... When no framework info or
|
Thanks for helping on this dear @ayoayco I have made some slight changes:
|
All sounds good! :) |
π Linked issue
#1954
β Type of change
π Description
Let me know if this is not the direction the project wants, I just assumed it is after seeing the new
framework
configuration :)This PR will show the framework name and version on dev server's build success.
π Checklist