Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cacheEventHandler): provide event.fetch and event.$fetch #2066

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

cjpearson
Copy link
Contributor

πŸ”— Linked issue

Fixes: #1848

Based on: #1968

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Based on the comment here, I tried to create the event.fetch utils in same way as in app.ts.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@cjpearson cjpearson force-pushed the fix/cache-handler-clone-fetch branch from bd48ded to 321dfb9 Compare February 5, 2024 13:24
@cjpearson
Copy link
Contributor Author

Hi @pi0, do you have any updates on if/when this might be merged? Or if there are changes necessary. Sorry to keep bugging you, but this is an important issue for us since it blocks enabling page caching.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix: provide fetch utils to cacheEventHandler event using wrapper fix(cacheEventHandler): provide event.fetch and event.$fetch Feb 27, 2024
@pi0 pi0 merged commit fcc4918 into nitrojs:main Feb 27, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event.$fetch is not available when caching is enabled
3 participants