Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file extension stripping in writeTypes function #2139

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

productdevbook
Copy link
Contributor

@productdevbook productdevbook commented Feb 6, 2024

🔗 Linked issue

❓ Type of change

  const connectPostgresJS: typeof import('../../../../node_modules/.pnpm/@pergel+nuxt@0.7.19_nuxt@3.9.3_rollup@4.9.6_vite@5.0.12_vue@3.4.15/node_modules/@pergel/nuxt/dist/runtime/modules/drizzle/drivers/postgres/export.mjs')['connectPostgresJS']

fixed pr

  const connectPostgresJS: typeof import('../../../../node_modules/.pnpm/@pergel+nuxt@0.7.19_nuxt@3.9.3_rollup@4.9.6_vite@5.0.12_vue@3.4.15/node_modules/@pergel/nuxt/dist/runtime/modules/drizzle/drivers/postgres/export')['connectPostgresJS']
  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep the isDirectory check or it will strip dots from folders.

@productdevbook
Copy link
Contributor Author

@danielroe fixed.

@danielroe
Copy link
Member

Thank you ❤️

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@pi0 pi0 merged commit 9730a44 into nitrojs:main Feb 27, 2024
4 checks passed
@productdevbook productdevbook deleted the strip-extension branch February 27, 2024 17:21
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants